[PATCH] D24974: Add build script for symbolizer which can be linked into instrumented process.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc:21
@@ +20,3 @@
+static llvm::symbolize::LLVMSymbolizer *getDefaultSymbolizer() {
+  static llvm::symbolize::LLVMSymbolizer *DefaultSymbolizer = 0;
+  if (DefaultSymbolizer == 0) {
----------------
nullptr

================
Comment at: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:15
@@ +14,3 @@
+#   adding a dependency on Sanitizer runtime library.
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
----------------
Please update the comment.

================
Comment at: test/asan/TestCases/Linux/print_memory_profile_test.cc:33
@@ +32,2 @@
+// CHECK-50: 2227000 byte(s) ({{.*}}%) in 17 allocation(s)
+// CHECK-50-NOT: allocation
----------------
I don't understand the effect of this change.


https://reviews.llvm.org/D24974