[PATCH] D20046: [AVR] Add assembly parser

[Krzysztof Parzyszek via llvm-commits]

kparzysz added a subscriber: kparzysz.

================
Comment at: lib/Target/AVR/AsmParser/AVRAsmParser.cpp:30
@@ +29,3 @@
+#include "AVRRegisterInfo.h"
+#include "MCTargetDesc/AVRMCExpr.h"
+
----------------
Local includes usually go first and are sorted alphabetically, if there are no reasons against it.

================
Comment at: lib/Target/AVR/AsmParser/AVRAsmParser.cpp:449
@@ +448,3 @@
+    return false;
+  } else {
+    // Not a reloc expr
----------------
Avoid else after return.  Also, the condition could be inverted and made into an early "return true".

================
Comment at: lib/Target/AVR/AsmParser/AVRAsmParser.cpp:563
@@ +562,3 @@
+      continue;
+    } else if (MatchResult == MatchOperand_ParseFail) {
+      SMLoc Loc = getLexer().getLoc();
----------------
Avoid else after continue.


Repository:
  rL LLVM

https://reviews.llvm.org/D20046