[PATCH] D24976: [thinlto] Don't decay threshold for hot callsites
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 27 12:11:14 PDT 2016
tejohnson added a comment.
(As discussed offline, Piotr will test on SPEC and get back with performance data).
================
Comment at: test/Transforms/FunctionImport/hotness_based_import.ll:38
@@ -33,1 +37,3 @@
+; for hot callsites the threshold doesn't decay, that's why it doesn't make difference if the import factor
+; is 0 or higher - calledFromHot's will be imported
; RUN: opt -function-import -summary-file %t3.thinlto.bc %t.bc -import-instr-limit=10 -import-hot-multiplier=0.0 --S | FileCheck %s --check-prefix=CHECK --check-prefix=HOT-ZERO
----------------
Comment doesn't make much sense - we are checking that they aren't imported.
https://reviews.llvm.org/D24976
More information about the llvm-commits
mailing list