[PATCH] D24647: [CUDA] [test-suite] Always enable assert()s in our builds.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 11:04:09 PDT 2016


MatzeB added a comment.

In https://reviews.llvm.org/D24647#553483, @jlebar wrote:

> > In any case we could move -DNDEBUG from the global CMakeLists.txt file to {SingleSource|MultiSource|External}/CMakeLists.txt (or even further down the hierarchy when we know which tests actually need it for correctness).
>
>
> It sounds like this would have impacts on all of the other LLVM projects, though?  In which case maybe what we have here is the least bad option?


as long as you just push it the setting down the tree and just not into the CUDA directory, it shouldn't affect anyone. Also -DNDEBUG is used by default in the Release build setting which are default as well in the testsuite so the flag is only missing if someone explicitely overrides the flags.


https://reviews.llvm.org/D24647





More information about the llvm-commits mailing list