[PATCH] D24880: Add StringExtras join_items function

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 08:59:39 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: include/llvm/ADT/StringExtras.h:226
@@ +225,3 @@
+  return join_one_item_size(A) +
+         join_items_size(B, std::forward<Args>(Items)...);
+}
----------------
Do you need the B in this function?


https://reviews.llvm.org/D24880





More information about the llvm-commits mailing list