[PATCH] D24880: Add StringExtras join_items function
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 27 08:54:12 PDT 2016
mehdi_amini added inline comments.
================
Comment at: include/llvm/ADT/StringExtras.h:246
@@ +245,3 @@
+ size_t NI = detail::join_items_size(std::forward<Args>(Items)...);
+ Result.reserve(NI + (sizeof...(Items) - 1) * NS);
+ detail::join_items_impl(Result, Separator, std::forward<Args>(Items)...);
----------------
Isn't there a missing + 1 for the trailing '\0' ?
https://reviews.llvm.org/D24880
More information about the llvm-commits
mailing list