[PATCH] D24925: [testsuite] turn fp-contract off because we can check those results more precisely

[Sanjay Patel via llvm-commits]

spatel retitled this revision from "[testsuite] turn fp-contract off for ARM because output checking is not flexible enough" to "[testsuite] turn fp-contract off because we can check those results more precisely".
spatel updated the summary for this revision.
spatel updated this revision to Diff 72560.
spatel added a comment.

Patch/title/summary updated:
After re-reading Hal and Steve's Sept 23 replies and in light of today's comments, I realize that I unnecessarily made the change about ARM when the arguments really apply to *all* targets. Sorry about that.

Also, I still don't know how to check this locally, and it's not clear to me how to make the change apply to a cmake build. If this patch has any hope of going forward, feel free to put me out of my misery and commandeer this patch! :)


https://reviews.llvm.org/D24925

Files:
  Makefile.config.in

Index: Makefile.config.in
===================================================================
--- Makefile.config.in
+++ Makefile.config.in
@@ -150,14 +150,12 @@
 XCORE_TARGET_FLAGS += -Wl,-Xmapper,--image-size,-Xmapper,$$(($(XCORE_TARGET_NEEDS_MEMORY) * 0x100000)),-Xmapper,--image-base,-Xmapper,$$(($(XCORE_TARGET_NEEDS_MEMORY) * 0x100000))
 endif
 
-# PowerPC/Linux needs -ffp-contract=off so that:
-#     The outputs can be compared to gcc.
-#     The outputs match the reference outputs.
-ifeq ($(ARCH),PowerPC)
-ifeq ($(TARGET_OS),Linux)
+# To allow for precise checking of tests with floating-point operations,
+# turn off fp-contract (FMA codegen). Ideally, we would run everything 
+# again with -ffp-contract=on and fix any output-checking that is not
+# prepared for that possibility.
 TEST_TARGET_FLAGS += -ffp-contract=off
-endif
-endif
+
 
 #
 # Provide variables specific to llvm-test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24925.72560.patch
Type: text/x-patch
Size: 900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160926/95576776/attachment.bin>