[PATCH] D24638: [thinlto] Basic thinlto fdo heuristic

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM thanks!


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:6464
@@ +6463,3 @@
+  GlobalValue::GUID CalleeGUID = getGUIDFromValueId(CalleeValueId).first;
+  if (IsOldProfileFormat)
+    I += 1; // Skip old field - callsite_count.
----------------
Prazek wrote:
> tejohnson wrote:
> > I think this block would be clearer if restructured like:
> > 
> > if (IsOldProfileFormat) {
> >    I += 1; // Skip old callsitecount field
> >    if (HasProfile)
> >       I += 1; // Skip old profilecount field
> > } else
> >    Hotness = static_cast<CalleeInfo::HotnessType>(Record[++I]);
> > ...
> > 
> > (Note the ++I change in the Record access too)
> what do you mean with "(Note the ++I change in the Record access too)"
> I agree that your structure is better.
> what do you mean with "(Note the ++I change in the Record access too)"
I just was calling attention to the fact that this line was different than what your old structure required. Looks like you adapted this change fine.


https://reviews.llvm.org/D24638