[PATCH] D24772: [ValueTracking] Fix crash in GetPointerBaseWithConstantOffset()

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 12:21:32 PDT 2016

Previous message: [PATCH] D22630: Loop rotation
Next message: [llvm] r282341 - [X86] Teach combineShuffle to avoid creating floating point operations with integer types and integer operations with floating point types. Seems isOperationLegal lies for mismatched types and operations.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm

Btw, this looks like a good reason to change `accumulateConstantOffset` to return an `Optional<APInt>` of the right bitwidth.


https://reviews.llvm.org/D24772

Previous message: [PATCH] D22630: Loop rotation
Next message: [llvm] r282341 - [X86] Teach combineShuffle to avoid creating floating point operations with integer types and integer operations with floating point types. Seems isOperationLegal lies for mismatched types and operations.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list