[PATCH] D24925: [testsuite] turn fp-contract off for ARM because output checking is not flexible enough

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 12:13:55 PDT 2016


On 26 September 2016 at 20:07, Stephen Canon <scanon at apple.com> wrote:
> I agree with Hal, but would go a little bit further: we should really be
> running these tests twice.  First, for platforms with FLOAT_EVAL_METHOD=0 in
> -ffp-contract=off with a bit-exact result requirement, and second for all
> platforms with -ffp-contract=on and only checking that the appropriate error
> bound is satisfied (i.e. *no* comparison to previous results, only the
> established bound).

I agree we should test both, but given we only have hardware to test
one, testing what the user will see is the only one we *can* do.

cheers,
--renato


More information about the llvm-commits mailing list