[PATCH] D24925: [testsuite] turn fp-contract off for ARM because output checking is not flexible enough

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 11:40:55 PDT 2016


MatzeB added a comment.

Two comments:

1. If these fp-contract changes are enough to break various test-suite tests then we will see the same effects for other compiler users. So please put some explanation (and ideally also some way to deal with such issues) in the release notes!
2. Is there a list of broken benchmarks somewhere? I don't see anyone doing numerical analysis on the test-suite benchmarks, what you can today though is telling the test-suite to use fpcmp for comparing the results and set some absolute or relative tolerances.


https://reviews.llvm.org/D24925





More information about the llvm-commits mailing list