[PATCH] D24904: Allow StringRef to be constructed with a null pointer

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 11:10:40 PDT 2016


zturner added a comment.

In https://reviews.llvm.org/D24904#552657, @mehdi_amini wrote:

> > Marking the `const char *` constructor explicit means you won't be able to write `foo("Test")` anymore, which would be really unfortunate.  There might be a way to hack around it with some overload / template magic, but I tried and couldn't get it to work.
>
>
> I have a patch that does that (adding the template ctor for string literal), and I'm updating the LLVM codebase locally before submitting.


Mind if I take a quick look before you submit?  I tried my darndest and couldn't get it to work, so idk if you're just better than me or if it doesn't work with MSVC.  :)  Either way I want to try it locally and see if it works.


https://reviews.llvm.org/D24904





More information about the llvm-commits mailing list