[PATCH] D24925: [testsuite] turn fp-contract off for ARM because output checking is not flexible enough
Steve Canon via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 26 10:56:29 PDT 2016
scanon added a comment.
The tests in question are broken. They blindly apply a relative error tolerance that is not motivated by sound numerical analysis, despite the existence of well-known and well-founded error bounds for these problems, in every basic numerical analysis textbook.
That said, this doesn't actually fix the issue. It's a band-aid that allows the other patch to proceed. Since you seem to want to block that change in the short-term, there's probably not much point in proceeding with this one.
If someone has the time to devote to a correct fix for these tests, I can help them with the mathematically-correct error bounds.
https://reviews.llvm.org/D24925
More information about the llvm-commits
mailing list