[PATCH] D24927: Propagate DBG_VALUE entries when there are unvisited predecessors

[Adrian Prantl via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Generally looks good to me.
The testcase appears to be a bit fragile — it might make sense to convert this to a MIR testcase so we aren't depending on random codegen choices.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:384
@@ +383,3 @@
+    // Ignore unvisited predecessor blocks.  As we are processing
+    // the blocks in reversie post-order any unvisited block can
+    // be concidered to not remove any incoming values.
----------------
reverse

================
Comment at: test/CodeGen/ARM/dbg-range-extension.ll:3
@@ +2,3 @@
+;
+; Check that the debug information for variables are probogated into the correct blocks.
+;
----------------
propagated


https://reviews.llvm.org/D24927