[PATCH] D24899: [ELF] Don't warn about missing start symbol in relocatable and shared files

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 09:52:12 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:679
@@ -677,3 +678,3 @@
   }
   if (!HasEntryAddr) {
     if (Symtab.find(Config->Entry))
----------------
HasEntry and HasEntryAddr seem a bit confusing here. I think you only had to change this line to

  if (!HasEntryAddr && !Config->Entry.empty()) {

no?


https://reviews.llvm.org/D24899





More information about the llvm-commits mailing list