[PATCH] D24857: [ARM] Assign cost of scaling used in addressing mode for ARM cores

[Renato Golin via llvm-commits]

rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

Hi Javed,

The improvements are indeed impressive, but the implementation is in the wrong place. We're moving away from using CPU flags and CPU specific code gen decisions. We need to move this into a proper cost model.

cheers,
--renato


================
Comment at: lib/Target/ARM/ARMSubtarget.h:415
@@ -414,1 +414,3 @@
   bool isCortexA15() const { return ARMProcFamily == CortexA15; }
+  bool isCortexA53() const { return ARMProcFamily == CortexA53; }
+  bool isCortexA57() const { return ARMProcFamily == CortexA57; }
----------------
We don't want these at all. Please, make sure this is a feature flag, or a cost model / scheduler decision.


https://reviews.llvm.org/D24857