[PATCH] D23984: [X86] Fix bug in masked compress
Elena Demikhovsky via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 25 06:20:36 PDT 2016
delena added inline comments.
================
Comment at: include/llvm/CodeGen/SelectionDAG.h:972
@@ -972,1 +971,3 @@
+ MachineMemOperand *MMO, bool IsTrunc,
+ bool isCompressing = false);
SDValue getMaskedGather(SDVTList VTs, EVT VT, const SDLoc &dl,
----------------
wrong code alignment
================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:1974
@@ -1970,1 +1973,3 @@
+ bool isCompressingStore() const { return StoreSDNodeBits.IsCompressing; }
+
----------------
Please add comments before the API. Please explain carefully what the compression means.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18829
@@ -18830,1 +18828,3 @@
+ return DAG.getMaskedStore(Chain, dl, DataToCompress, Addr, VMask, VT,
+ MemIntr->getMemOperand(), false, true);
}
----------------
Code alignment
https://reviews.llvm.org/D23984
More information about the llvm-commits
mailing list