[PATCH] D24441: [AA] Add the notion of target-specific alias analyses.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 24 12:34:27 PDT 2016


jlebar added a comment.

In https://reviews.llvm.org/D24441#551627, @hfinkel wrote:

> It seems somewhat unfortunate to have both ExternalAAWrapperPass and TargetSpecificAAWrapperPass. It also seems unfortunate that we can only ever have one external AA provider. What if we let ExternalAAWrapperPass contain an array of callbacks and let the target add to that array?


That seems simple enough.  We'd need to change the external wrapper pass to use AAResultsProvider (a raw callback isn't going to work for a target-specific pass, see the commit message), but if anything I think that will be a simplification for clients of the external thing.


https://reviews.llvm.org/D24441





More information about the llvm-commits mailing list