[PATCH] D24891: [ELF] Support -z max-page-size option

[Davide Italiano via llvm-commits]

davide added a subscriber: davide.
davide added a comment.

Out of curiosity, are you using this option anywhere?
I think this is semantically fine if you have an use case, I left some comments around.


================
Comment at: ELF/Driver.cpp:660
@@ -659,1 +659,3 @@
 
+  // Initialize Config->MaxPageSize
+  if (Optional<StringRef> Value = getZOptionValue(Args, "max-page-size")) {
----------------
You might want to elaborate this a bit. Maybe, mentioning that there's a target default MAXPAGESIZE anyway and this option overrides the value.

================
Comment at: test/ELF/zmax-page-size.s:1
@@ +1,2 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
----------------
Linker script tests go in ELF/linkerscript


https://reviews.llvm.org/D24891