[PATCH] D24587: [RFC] Output optimization remarks in YAML

[Adam Nemet via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D24587#550951, @hfinkel wrote:

>   ORE.emit(DiagnosticInfoOptimizationRemarkMissed(DEBUG_TYPE, &I, "InlinerNotInlined")
>            << NV("Callee", Callee) << " will not be inlined into "
>            << NV("Caller", CS.getCaller()));
>   
>
> Where NV is supposed to stand for "named value", and the idea being that the name is used as the key for the YAML output.


I think that this makes a lot of sense! Thanks for your input!


================
Comment at: lib/Analysis/OptimizationDiagnosticInfo.cpp:131
@@ +130,3 @@
+  else
+    F->getContext().diagnose(OptDiag);
+}
----------------
hfinkel wrote:
> Why don't we call this regardless of whether we're saving the output? We might not want to change which messages the user sees while compiling just because we're also recording the output (I don't think that we do).
Makes sense.  The backend user can decide not to emit it at the higher level.

This is probably that we should use now for IsVerbose (D23415).



https://reviews.llvm.org/D24587