[PATCH] D23089: llc: Add -start-before/-stop-before options

[Matthias Braun via llvm-commits]

MatzeB added inline comments.

================
Comment at: include/llvm/CodeGen/TargetPassConfig.h:151
@@ +150,3 @@
+           "Start after and start before passes are given");
+    assert(!(StopBefore && StopAfter) &&
+           "Stop after and stop before passed are given");
----------------
qcolombet wrote:
> hfinkel wrote:
> > These asserts should be report_fatal_error; the user might trigger them with bad command-line options (and I assume we still want them in release builds).
> Agreed. A follow-up commit is fine given we use to assert on that already.
I'll leave this as an assert, but will add some error handling/catching for this case to llc.

Reasoning: I'd like to keep the llvm free of (unnecessary) commandline handling logic, that's the frontends job IMO (llc in this case). Ideally we would have all of this start/stop/before/after handling purely in llc, however when I tried to do that it turned out to be quite tricky so I left the code as is and went for the easy enhancement.


Repository:
  rL LLVM

https://reviews.llvm.org/D23089