[PATCH] D24885: [profile] Hide lprofCurFilename

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 13:58:58 PDT 2016


vsk created this revision.
vsk added a reviewer: davidxl.
vsk added a subscriber: llvm-commits.

Apple has a build verification step which complains when external symbols are introduced into a project, if they're not defined in some header. When building programs for profiling we need to expose VPMergeHook, _llvm_profile_filename, and __llvm_profile_raw_version so we've whitelisted these. I don't think we need to expose lprofCurFilename.

https://reviews.llvm.org/D24885

Files:
  lib/profile/InstrProfilingFile.c

Index: lib/profile/InstrProfilingFile.c
===================================================================
--- lib/profile/InstrProfilingFile.c
+++ lib/profile/InstrProfilingFile.c
@@ -82,7 +82,8 @@
   ProfileNameSpecifier PNS;
 } lprofFilename;
 
-lprofFilename lprofCurFilename = {0, 0, 0, {0}, {0}, 0, 0, 0, PNS_unknown};
+static lprofFilename lprofCurFilename = {0, 0, 0, {0}, {0},
+                                         0, 0, 0, PNS_unknown};
 
 int getpid(void);
 static int getCurFilenameLength();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24885.72353.patch
Type: text/x-patch
Size: 509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160923/ef5c2349/attachment.bin>


More information about the llvm-commits mailing list