[lld] r282248 - [ELF] - Linkerscript: accept space between '=' and expression in section filler.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 23 06:29:20 PDT 2016
Author: grimar
Date: Fri Sep 23 08:29:20 2016
New Revision: 282248
URL: http://llvm.org/viewvc/llvm-project?rev=282248&view=rev
Log:
[ELF] - Linkerscript: accept space between '=' and expression in section filler.
Previously we failed to parse next scripts because disallowed
a space between filler value and '=':
.text : {
...
} :text = 0x9090
Differential revision: https://reviews.llvm.org/D24831
Modified:
lld/trunk/ELF/LinkerScript.cpp
lld/trunk/test/ELF/linkerscript/sections-padding.s
Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=282248&r1=282247&r2=282248&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Fri Sep 23 08:29:20 2016
@@ -1275,8 +1275,12 @@ ScriptParser::readOutputSectionDescripti
setError("unknown command " + Tok);
}
Cmd->Phdrs = readOutputSectionPhdrs();
- if (peek().startswith("="))
+
+ if (skip("="))
+ Cmd->Filler = readOutputSectionFiller(next());
+ else if (peek().startswith("="))
Cmd->Filler = readOutputSectionFiller(next().drop_front());
+
return Cmd;
}
Modified: lld/trunk/test/ELF/linkerscript/sections-padding.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/linkerscript/sections-padding.s?rev=282248&r1=282247&r2=282248&view=diff
==============================================================================
--- lld/trunk/test/ELF/linkerscript/sections-padding.s (original)
+++ lld/trunk/test/ELF/linkerscript/sections-padding.s Fri Sep 23 08:29:20 2016
@@ -31,6 +31,11 @@
# RUN: | FileCheck --check-prefix=ERR2 %s
# ERR2: invalid filler expression: 0x99XX
+## Check case with space between '=' and expression:
+# RUN: echo "SECTIONS { .mysec : { *(.mysec*) } = 0x1122 }" > %t.script
+# RUN: ld.lld -o %t.out --script %t.script %t
+# RUN: llvm-objdump -s %t.out | FileCheck -check-prefix=YES %s
+
.section .mysec.1,"a"
.align 16
.byte 0x66
More information about the llvm-commits
mailing list