[PATCH] D24830: [ELF] - Linkerscript: implemented BYTE/SHORT/LONG/QUAD commands.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 23 04:52:27 PDT 2016
rafael added inline comments.
================
Comment at: ELF/LinkerScript.h:146
@@ +145,3 @@
+ static bool classof(const BaseCommand *C);
+ uint64_t Data;
+ unsigned Offset;
----------------
This could just store a StringRef or ArrayRef, no?
We can compute the correct (target endian) representation upfront and simplify the remaining code.
https://reviews.llvm.org/D24830
More information about the llvm-commits
mailing list