[PATCH] D24832: [ELF] Resolve weak undefined TLS symbols when no phdr is available

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 18:35:34 PDT 2016


ruiu added a subscriber: ruiu.

================
Comment at: ELF/InputSection.cpp:249
@@ +248,3 @@
+    // statically to zero.
+    if (Body.isTls() && Body.isLazy() && Body.symbol()->isWeak())
+      return 0;
----------------
We should never call getSymVA() on a lazy symbol, so isLazy() is always false. But if so, your code cannot change the behavior of this function. So something's not correct.


https://reviews.llvm.org/D24832





More information about the llvm-commits mailing list