[PATCH] D24741: [MC] Support .dcb directives in assembler parser

[Davide Italiano via llvm-commits]

davide added a comment.

Feel free to submit after fixing my second round of comments, no need for another back and forth. Thanks!


================
Comment at: lib/MC/MCParser/AsmParser.cpp:275-276
@@ -274,2 +274,4 @@
 
+  bool parseRealValue(const fltSemantics &Semantics, APInt &Res);
+
   /// \brief Parse an identifier or string (as a quoted identifier)
----------------
This is not your fault (partly, but a large amount of the `parse*` methods don't have a doxygen comment). 
Do you mind to add one to this one?

================
Comment at: lib/MC/MCParser/AsmParser.cpp:1919-1921
@@ -1911,4 +1918,5 @@
       return parseDirectiveValue(2);
     case DK_DC_X:
       return TokError(Twine(IDVal) +
                       " not currently supported for this target");
+    case DK_DCB:
----------------
This and the condition at line 1933 can be merged together, no?


Repository:
  rL LLVM

https://reviews.llvm.org/D24741