[PATCH] D24842: Add StringRef {take, drop} x {_while, _until}

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 14:01:48 PDT 2016


davide added inline comments.

================
Comment at: include/llvm/ADT/StringRef.h:499-500
@@ -498,1 +498,4 @@
 
+    template <typename Func>
+    LLVM_ATTRIBUTE_UNUSED_RESULT StringRef take_while(Func F) const {
+      StringRef S(*this);
----------------
Oh, and maybe if you can add a comment at the beginning of each function (e.g. as consume_front() already does) it would be good. 


https://reviews.llvm.org/D24842





More information about the llvm-commits mailing list