[PATCH] D24736: [msan] Prevent initialization failure with newer (2.23+) glibc in use.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 13:44:13 PDT 2016


eugenis accepted this revision.
eugenis added a comment.

LGTM w/ nit


================
Comment at: lib/asan/asan_malloc_linux.cc:81
@@ -80,3 +80,3 @@
     uptr copy_size = Min(size, kDlsymAllocPoolSize - offset);
-    void *new_ptr = asan_malloc(size, &stack);
+    void *new_ptr = AllocateFromLocalPool(size);
     internal_memcpy(new_ptr, ptr, copy_size);
----------------
if (UNLIKELY(!asan_inited)) AllocateFromLocalPool else asan_malloc

This probably does not matter in practice, but we should not keep reallocating in the local pool when the main allocator is available.


Repository:
  rL LLVM

https://reviews.llvm.org/D24736





More information about the llvm-commits mailing list