[PATCH] D23172: IfConversion: Add implicit uses for live subregisters

[Matthias Braun via llvm-commits]

MatzeB added inline comments.

================
Comment at: test/CodeGen/Hexagon/ifcvt-live-subreg.mir:2
@@ +1,3 @@
+# RUN: llc -march=hexagon -run-pass if-converter -o - %s | FileCheck %s
+# CHECK: %d8 = L2_ploadrdf_io %p0, %r29, 0, implicit %r17
+
----------------
Always good to see a small and to the point test.

- I'd add a sentence about what is tested.
- It's good style to have at least one `CHECK-LABEL: name: foo` in case someone adds more functions later (also sometimes protects you from accidentally matching random output before the function starts).
- I'd also go and CHECK for all if-converted instructions to make it a bit more obvious what is happening here.


Repository:
  rL LLVM

https://reviews.llvm.org/D23172