[PATCH] D24622: LTO: Simplify caching interface.

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

Sorry for the delay in review. Looks like a nice cleanup! Looks pretty good to me, but I have a question, which may mean that I am not understanding something.


================
Comment at: tools/gold/gold-plugin.cpp:801
@@ -800,3 +785,1 @@
                       MaxTasks > 1 ? Task : -1);
-    IsTemporary[Task] = !SaveTemps && options::cache_dir.empty();
-    if (options::cache_dir.empty())
----------------
Removing the "&& options::cache_dir.empty()" seems like it would cause gold-plugin to remove the cache file, which is why I added that here when I added caching.


https://reviews.llvm.org/D24622