[PATCH] D24466: [PPC] Set SP after loading data from stack frame, if no red zone is present

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 09:31:03 PDT 2016


hfinkel added a comment.

LGTM


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1039
@@ +1038,3 @@
+            .addReg(BPReg, RegState::Kill)  // Save BP.
+            .addReg(PPC::ZERO)    // This will be treated as 0.
+            .addReg(ScratchReg);  // This will be the index (R0 is ok here).
----------------
Don't need the "will be treated as 0" comment here.


Repository:
  rL LLVM

https://reviews.llvm.org/D24466





More information about the llvm-commits mailing list