[PATCH] D24667: [mips][ias] Handle more complicated expressions for memory operands

[Vasileios Kalintiris via llvm-commits]

vkalintiris requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:4447-4453
@@ +4446,9 @@
+      case AsmToken::AmpAmp:         Opcode = MCBinaryExpr::LAnd; break;
+      case AsmToken::EqualEqual:     Opcode = MCBinaryExpr::EQ;   break;
+      case AsmToken::ExclaimEqual:   Opcode = MCBinaryExpr::NE;   break;
+      case AsmToken::Less:           Opcode = MCBinaryExpr::LT;   break;
+      case AsmToken::LessEqual:      Opcode = MCBinaryExpr::LTE;  break;
+      case AsmToken::LessLess:       Opcode = MCBinaryExpr::Shl;  break;
+      case AsmToken::Greater:        Opcode = MCBinaryExpr::GT;   break;
+      case AsmToken::GreaterEqual:   Opcode = MCBinaryExpr::GTE;  break;
+      case AsmToken::GreaterGreater: Opcode = MCBinaryExpr::LShr; break;
----------------
We should test the comparison/equality operators in MC/Mips/memory-offsets.s as well. Can you check that we follow the GNU assembler behaviour for these?


https://reviews.llvm.org/D24667