[PATCH] D24544: SpeculativeExecution: Stop using whitelist for costs

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 08:02:42 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D24544#546434, @reames wrote:

> I'd suggest looking over the isSafeToSpeculate code carefully.  If we had any bugs there, this whitelist might have been helping to cover over them in practice.  In particular, the default: return true; case in that function looks suspicious.  You might want to convert that into a fully covered switch and cross reference the two lists to make sure this change isn't accidentally semantic.
>
> Assuming you've done the above, LGTM.


I only noticed what https://reviews.llvm.org/D24542 fixes, but it's possible I missed something else


https://reviews.llvm.org/D24544





More information about the llvm-commits mailing list