[PATCH] D24762: Alternative fix for empty sections

[Eugene Leviant via llvm-commits]

Are you actually suggesting converting symbols, like I did in
https://reviews.llvm.org/D24230 ?
If so, I'd remove those dummy sections as well later. But let's push
this, I have too many things to merge :-(

2016-09-22 16:44 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>:
> On 20 September 2016 at 10:24, Eugene Leviant <evgeny.leviant at gmail.com> wrote:
>> evgeny777 added a comment.
>>
>> On some occasions this may create empty special sections like .tbss, .eh_frame_hdr and others. Are you sure this is really harmless?
>
> Sorry for the crazy delay in replying. This patch was actually very
> good in finding other bugs when doing a bootstrap with frankenstein
> ld.
>
> One issue was in the patch itself: We were not tracking the type, only
> the flags.
>
> The other issues were the unstable sort and TLS handling bugs.
>
> In any case, this now survives a bootstrap and at most can cause a
> PT_LOAD to be extended to include padding. I will include that as a
> testcase and commit.
>
> A variation that came to mind that might be useful if we find another
> problem: move the contents out of the section. That is, turn
>
> foo : { abc = .; }
>
> into just
>
> abc = .;
>
> Cheers,
> Rafael