[PATCH] D24661: More processors support under AARch64 state for auto detection.

Suprateeka R Hegde via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 03:02:32 PDT 2016


On 21-Sep-2016 08:19 PM, James Greenhalgh wrote:
> I would find it surprising if passing -mcpu=xgene1 to Clang enabled
> generation of instructions from the CRC extension, as these would
> cause a SIGILL on my (and as far as I am aware, all) X-Gene 1
> machines.

I have fixed this. The patch is updated. Thanks a lot for pointing this out.

On 20-Sep-2016 01:38 AM, Renato Golin wrote:
> Since this is not fixing a bug or anything, I don't think it's worth
> putting as is and making it better later.

BTW, note that currently (without this patch), there is no 
auto-detection at all on AArch64. That means, for instance, on a 
cortex-a57 machine, -mcpu=native returns "unknown" and even though 
scheduler optimizations exist specific to cortex-a57 
(AArch64SchedA57.td), it will not be used. And hence, "generic" 
(un-optimized) model would be used.

--
Supra


More information about the llvm-commits mailing list