[PATCH] D24505: [mips][fastisel] Consider soft-float an unsupported floating point mode

[Vasileios Kalintiris via llvm-commits]

vkalintiris added inline comments.

================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1368
@@ -1367,1 +1367,3 @@
     case MVT::f32:
+      if (Subtarget->useSoftFloat()) {
+        DEBUG(dbgs() << ".. .. gave up (useSoftFloat())\n");
----------------
We should check `UnsupportedFPMode` instead of `useSoftFloat` in order to be consistent with similar tests in other places.

================
Comment at: test/CodeGen/Mips/Fast-ISel/fast-isel-softfloat-lower-args.ll:1
@@ +1,2 @@
+; RUN: not llc -march=mipsel -mcpu=mips32r3 -mattr=+micromips,+soft-float \
+; RUN:         -fast-isel -fast-isel-abort=3 -relocation-model=pic < %s
----------------
FastISel is not enabled for microMIPS as we haven't test this configuration. Also, try to enable FastISel by using `-O0` and `-relocation-model=pic` as we do on (hopefully most of) the other tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D24505