[PATCH] D24816: [Target] move reciprocal estimate settings from TargetOptions to TargetLowering

[Sanjay Patel via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D24816#549293, @mehdi_amini wrote:

> > IMO, it needs even finer granularity than the function - I'd like to get this on instructions similar to other FMF attributes. We have users that want to selectively vary the codegen for sqrt/div within a function using source code pragmas.
>
>
> It seems this patch does not get you any closer from this goal?


There are independent goals, but I see this is an intermediate step:

1. It allows the settings to be different per function.
2. The settings survive in an LTO build. AFAIK, currently we drop all reciprocal settings with LTO.
3. It allows https://reviews.llvm.org/rL268539 to be reimplemented. Not sure if there are other barriers for that though?


https://reviews.llvm.org/D24816