[PATCH] D24805: [GVNSink] Initial GVNSink prototype

Aditya Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 14:13:36 PDT 2016


hiraditya added inline comments.

================
Comment at: lib/Transforms/Scalar/GVN.cpp:348
@@ +347,3 @@
+  for (auto &U : I->uses())
+    e.varargs.push_back(lookupOrAdd(U.getUser()));
+  std::sort(e.varargs.begin(), e.varargs.end());
----------------
For an instruction with no-uses e.g. a store, this function will return e with only type and opcode initialized. How will that instruction get sunk?


Repository:
  rL LLVM

https://reviews.llvm.org/D24805





More information about the llvm-commits mailing list