[PATCH] D24748: Win64: Don't emit unwind info for "leaf" functions (PR30337)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 13:57:52 PDT 2016


rnk added a comment.

+1 to David's comments, otherwise looks good


================
Comment at: include/llvm/CodeGen/MachineFunction.h:378-379
@@ -374,1 +377,4 @@
 
+  bool hasWinCFI() const { return HasWinCFI; }
+  void setHasWinCFI(bool v) { HasWinCFI = v; }
+
----------------
majnemer wrote:
> I'd sleep a little easier at night if `HasWinCFI` was an optional bool.  This way we can make sure that nobody is trying to access it before we calculate the state the function is in.
This is a good idea, we should do this more often.


https://reviews.llvm.org/D24748





More information about the llvm-commits mailing list