[PATCH] D24778: Add `StringRef::consumeInteger`

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 12:59:25 PDT 2016


zturner added inline comments.

================
Comment at: include/llvm/ADT/StringRef.h:414
@@ +413,3 @@
+    consumeInteger(unsigned Radix, T &Result) {
+      long long LLVal;
+      if (consumeSignedInteger(*this, Radix, LLVal) ||
----------------
mehdi_amini wrote:
> Is the intent to provide 64 bits here? If so why not using int64_t?
Good question.  I based this off the implementation in `getAsInteger` above.  I don't know if it makes a difference.  If you think `int64_t` is better LMK.


https://reviews.llvm.org/D24778





More information about the llvm-commits mailing list