[PATCH] D24781: [ubsan] Respect log_to_syslog=1 on Darwin

Anna Zaks via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 20:48:45 PDT 2016


zaks.anna added a comment.

> No, I don't have plans to do this. The typical workflow with ubsan is to continue after an error/warning is 

>  reported. In trap or abort mode, it's easier to run the instrumented program with a debugger than to rely 

>  on crashlog.


Are you sure that UBSan workflow should be different from TSan workflow? In my mind they are the same.

> I see your point that having different logging strategies is strange, but I think there are advantages to 

>  logging errors to syslog directly instead of doing it at exit.


Yes, this is the main downslide.

> For one, we're not limited by the fixed-size 

>  crashlog buffer. Secondly, we can extract errors from long-running apps or daemons without having to 

>  shut them down. In some situations (e.g Xcode UI Tests), instrumented apps are killed with SIGTERM 

>  and their atexit() handlers never run..


What would be the user workflow for the Xcode UI Tests? (Syslog is not a great communication channel in that case.)


https://reviews.llvm.org/D24781





More information about the llvm-commits mailing list