[PATCH] D24714: [MC] Support skip and count for .incbin directive

[Petr Hosek via llvm-commits]

phosek added a comment.

That would be awesome, they're not really related to this one but I'd like to land them as well.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:4407-4411
@@ +4406,7 @@
+  if (getLexer().isNot(AsmToken::EndOfStatement)) {
+    if (parseToken(AsmToken::Comma,
+                   "unexpected token in '.incbin' directive") ||
+        parseAbsoluteExpression(Skip))
+      return true;
+ 
+    if (getLexer().isNot(AsmToken::EndOfStatement)) {
----------------
davide wrote:
> this and the lines at 4413-4417 are identical. Can you factor out in a common helper?
This no longer relevant as these blocks are now different.


Repository:
  rL LLVM

https://reviews.llvm.org/D24714