[PATCH] D24714: [MC] Support skip and count for .incbin directive

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 18:53:47 PDT 2016


phosek updated this revision to Diff 72003.
phosek marked an inline comment as done.
phosek added a comment.

I did some more testing against GNU as and found out that it also allows skip to be empty, this behavior is now supported as well. I've also expanded error checking for negative skip and count values.


Repository:
  rL LLVM

https://reviews.llvm.org/D24714

Files:
  lib/MC/MCParser/AsmParser.cpp
  test/MC/AsmParser/directive_incbin.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24714.72003.patch
Type: text/x-patch
Size: 4728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160921/85ce87c2/attachment.bin>


More information about the llvm-commits mailing list