[PATCH] D24768: [compiler-rt] Fix Asan build on Android
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 13:54:42 PDT 2016
vitalybuka added inline comments.
================
Comment at: lib/asan/asan_rtl.cc:466
@@ -465,11 +465,3 @@
uptr shadow_start = kLowShadowBeg;
- if (shadow_start == 0) {
- uptr granularity = GetMmapGranularity();
- uptr alignment = 8 * granularity;
- uptr left_padding = granularity;
- uptr space_size = kHighShadowEnd + left_padding;
-
- shadow_start = FindAvailableMemoryRange(space_size, alignment, granularity);
- CHECK_NE((uptr)0, shadow_start);
- CHECK(IsAligned(shadow_start, alignment));
- }
+#if ASAN_DYNAMIC_SHADOW_ADDRESS
+ CHECK_EQ(0, shadow_start);
----------------
rnk wrote:
> I think kcc likes regular if over #if, when possible. Also, isn't this macro undefined usually?
Maybe ~0 instead of 0?
https://reviews.llvm.org/D24768
More information about the llvm-commits
mailing list