[PATCH] D24687: [llvm-cov] Add a project coverage summary above the index page.

Ying Yi via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 13:52:12 PDT 2016


MaggieYi updated this revision to Diff 71982.
MaggieYi added a comment.

In https://reviews.llvm.org/D24687#546833, @vsk wrote:

> I'd prefer to just tackle this issue in this patch. IMO it would be better to drop (or at least defer) the other changes.


Ok, I have updated the patch following your advice.

> This is intentional and it matches the behavior of the text reports. The longest-common prefix of the path names are stripped away to make it easier to see the filename. This prefix is visually distracting and doesn't convey any useful information.


If the project is branched, the longest-common prefix of the path (I called the project directory) will show the branch name. The project directory will tell the user where the source code come from.


https://reviews.llvm.org/D24687

Files:
  test/tools/llvm-cov/Inputs/showProjectSummary.test
  test/tools/llvm-cov/showProjectSummary.cpp
  tools/llvm-cov/SourceCoverageViewHTML.cpp
  tools/llvm-cov/SourceCoverageViewHTML.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24687.71982.patch
Type: text/x-patch
Size: 8928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160920/f2c0572d/attachment.bin>


More information about the llvm-commits mailing list