[PATCH] D24525: [Power9] Processor Model for Scheduling

[Eric Christopher via llvm-commits]

echristo added a comment.

More names for the functional units etc, more comments in general.

One important inline comment.

-eric


================
Comment at: lib/Target/PowerPC/P9InstrResources.td:207
@@ +206,3 @@
+      (instrs
+ //   VABSDUB,
+ //   VABSDUH,
----------------
No commented out lines without... well, comments.

================
Comment at: lib/Target/PowerPC/PPCTargetMachine.cpp:302
@@ +301,3 @@
+    : TargetPassConfig(TM, PM) {
+    if (TM->isPWR9() && TM->getOptLevel() != CodeGenOpt::None)
+      substitutePass(&PostRASchedulerID, &PostMachineSchedulerID);
----------------
No, this won't work. The subtarget can change on a function by function basis so you'll need to come up with an alternate way to do this.

Let's see what we can come up with...


https://reviews.llvm.org/D24525