[PATCH] D24661: More processors support under AARch64 state for auto detection.

Suprateeka R Hegde via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 08:26:18 PDT 2016


On 20-Sep-2016 01:38 AM, Renato Golin wrote:
  A simple library to decode
> cpuinfo would go a long way of making this manageable

Thats exactly what I meant by a software cpuid kind of facility. There 
is one libcpu available on github. We need something similar. We can 
then offload entire thing to that.

But at least for now, I (from HPE) can not spend time on such a thing. I 
can do it later, though.

On 20-Sep-2016 12:39 AM, Tim Northover wrote:
> I disagree. Looking through dozens of lines that may or may not be
>> identical after whatever patches have introduced Samsung, Qualcomm,
>> Apple, and whatever parsing is really something I want to avoid.
>>
>>> 4. The list may not really grow up to many such entries under one single
>>> implementer. In my opinion we can live with the penalty given other
>>> benefits.
>>
>> I'm still not seeing the benefits, I'm afraid.

OK. I shall make it a static array with assertions for sorted-ness.

Do you prefer separate ones under __aarch64__ and __arm__ or club both 
__arm__ and __aarch64__ together into one?

(I dont think the "CPU Part Number" would ever repeat/overlap across 
__arm__ and __aarch64__. So we may club it together)

--
Supra


More information about the llvm-commits mailing list