[PATCH] D24291: [mips] Add IAS support for dvp, evp

[Vasileios Kalintiris via llvm-commits]

vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM with a few minor changes, see inline comments.


================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:1351
@@ -1350,2 +1350,3 @@
   dag OutOperandList = (outs);
   dag InOperandList = (ins GPR32Opnd:$rs);
+  string AsmString = "evp\t$rs";
----------------
I believe that this should be an out operand.

================
Comment at: lib/Target/Mips/Mips32r6InstrFormats.td:48
@@ -47,2 +47,3 @@
 }
+def OPGROUP_COP0_DVPEVP : OPGROUP<0b010000>;
 def OPGROUP_COP1     : OPGROUP<0b010001>;
----------------
I don't think that we need the `_DVPEVP` suffix because we might need the COP0 opcode group again in the future.

================
Comment at: lib/Target/Mips/Mips32r6InstrInfo.td:911-912
@@ -885,3 +910,4 @@
 //===----------------------------------------------------------------------===//
-
+def : MipsInstAlias<"dvp", (DVP ZERO), 0>, ISA_MIPS32R6;
+def : MipsInstAlias<"evp", (EVP ZERO), 0>, ISA_MIPS32R6;
 let AdditionalPredicates = [NotInMicroMips] in {
----------------
Can you add tests for the aliases too?


Repository:
  rL LLVM

https://reviews.llvm.org/D24291