[PATCH] D23399: [mips][ias] fix li macro when values are negated with ~

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 07:34:57 PDT 2016


sdardis marked an inline comment as done.

================
Comment at: lib/Target/Mips/MipsInstrInfo.td:2384
@@ -2362,3 +2383,3 @@
 
 // We use i32imm on li/la to defer range checking to the assembler.
 class LoadImmediate32<string instr_asm, Operand Od, RegisterOperand RO> :
----------------
zoran.jovanovic wrote:
> Nit: Is this comment still valid?
No, it's not. I'll change it when I commit to "We use uimm32_coerced to accept a 33 bit signed number that is rendered into a 32 bit number." or similar.


https://reviews.llvm.org/D23399





More information about the llvm-commits mailing list