[PATCH] D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 06:51:37 PDT 2016


rSerge added a comment.

In https://reviews.llvm.org/D23933#546713, @rengolin wrote:

> In https://reviews.llvm.org/D23933#546615, @rSerge wrote:
>
> > I've tested
> >
> >   .arch armv6t2
> >   .fpu vfpv2
> >
> >
> > with Clang cross-compiling from x86_64-Windows to ARM-Linux and Thumb-Linux, and GCC cross-compiling from x86_64-Ubuntu to ARM-Linux and Thumb-Linux. No compile errors so far.
>
>
> Sorry, I wasn't clear. These two lines should work on any toolchain, my point is if that makes it break with your gnu toolchain because of the same issue (minimal ISA support assumed) in *conjunction* with the rest of the code.


That error doesn't seem to happen, at least with the toolchains I've tested.


https://reviews.llvm.org/D23933





More information about the llvm-commits mailing list